Fix category of point homsets of EllipticCurves and Jacobians#37768
Fix category of point homsets of EllipticCurves and Jacobians#37768grhkm21 wants to merge 13 commits intosagemath:developfrom
Conversation
`AbelianVarieties`. Also change base scheme of AbelianVarieties to be, well, a scheme.
|
It seems that this change is incorrect... an hyperelliptic curve jacobian |
|
To address this line: It seems that the problem is that point homsets, inherit from |
|
I just opened up a massive can of worms 🥳 TL;DR I shouldn't put the abelian group structure on Hom(X,AbGrp) yet, since that would require adding homs, which is kind of what #37705 does, except that does it for For now, I will revert that changes from this PR, and extract it to another issue. |
|
Documentation preview for this PR (built with commit 9eda621; changes) is ready! 🎉 |
|
I will close this PR for now, and split the changes into more smaller PRs. Basically I tried working on this PR just now and just made a mess so it's better to make smaller PRs. |
Fixes #37730.
There is a change to categories and homsets:
More TestSuite passes now:
(This used to fail quite spectacularly)
There are also many changes in algebraic geometry, such as:
Question for reviewer:
C.is_smooth()at the category check forJacobian_generic, but I think we also needCto have a rational point. Is that correct? How should I incorporate that?TODO:
TestSuite(asdf).run(), it seems like a cool feature